Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I

From: Kees Cook
Date: Mon Sep 13 2021 - 12:23:51 EST


On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote:
> The minimum supported version of GCC is now 5.1. The check wasn't
> correct as written anyways since GCC_VERSION is 0 when CC=clang.
>
> Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

Yeah, good catch for Clang too.

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook