Re: [PATCH misc v2 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

[Greg KH]

On Wed, Sep 15, 2021 at 02:47:09PM -0400, min.li.xe@xxxxxxxxxxx wrote:
> From: Min Li <min.li.xe@xxxxxxxxxxx>
> 
> This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families
> of timing and synchronization devices.It will be used by Renesas PTP Clock
> Manager for Linux (pcm4l) software to provide support to GNSS assisted
> partial timing support (APTS) and other networking timing functions.

Where is that software?

Why is this new api not a standard one?

What is the standard here?

What do other devices do and why is this a new api?

> Current version provides kernel API's to support the following functions
> -set combomode to enable SYNCE clock support
> -read dpll's state to determine if the dpll is locked to the GNSS channel
> -read dpll's ffo (fractional frequency offset) in ppqt

Why do all of these have to be in the kernel at all?

thanks,

greg k-h