Re: [PATCH rcu 10/14] rcu: Make rcutree_dying_cpu() use its "cpu" parameter

From: Peter Zijlstra
Date: Thu Sep 16 2021 - 03:29:17 EST


On Wed, Sep 15, 2021 at 04:33:39PM -0700, Paul E. McKenney wrote:
> The CPU-hotplug functions take a "cpu" parameter, but rcutree_dying_cpu()
> ignores it in favor of this_cpu_ptr(). This works at the moment, but
> it would be better to be consistent. This might also work better given
> some possible future changes. This commit therefore uses per_cpu_ptr()
> to avoid ignoring the rcutree_dying_cpu() function's argument.
>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx>

I think even in the old days dying and starting ran on the affected CPU,
and I don't ever see that changing.

Then again, none of this is hot-path in any way, so *meh* :-)