Re: [PATCH v2] perf test: Workload test of metric and metricgroups

From: John Garry
Date: Thu Sep 16 2021 - 03:37:50 EST


On 16/09/2021 07:05, Ian Rogers wrote:
Test every metric and metricgroup with 'true' as a workload.

Signed-off-by: Ian Rogers<irogers@xxxxxxxxxx>

Reviewed-by: John Garry <john.garry@xxxxxxxxxx>

Note that I also had a local test for pmu events:
for e in `$PERF list --raw-dump pmu`; do
echo "Testing $e"
result=$($PERF stat -v -e "$e" perf bench internals synthesize)
if [[ "$result" =~ "$e" ]]; then
echo "Event not printed: $e"
exit 1
fi
done

Is there any value in upstreaming this? I could not see same already there. Or else make your new script generic, so that it accepts an argument whether to test events or metrics or metricgroups