Re: [PATCH v2 1/2] power: supply: max17042_battery: Clear status bits in interrupt handler

From: Krzysztof Kozlowski
Date: Thu Sep 16 2021 - 06:26:12 EST


On 14/09/2021 14:18, Sebastian Krzyszkowiak wrote:
> The gauge requires us to clear the status bits manually for some alerts
> to be properly dismissed. Previously the IRQ was configured to react only
> on falling edge, which wasn't technically correct (the ALRT line is active
> low), but it had a happy side-effect of preventing interrupt storms
> on uncleared alerts from happening.
>
> Fixes: 7fbf6b731bca ("power: supply: max17042: Do not enforce (incorrect) interrupt trigger type")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@xxxxxxx>
> ---
> v2: added a comment on why it clears all alert bits
> ---
> drivers/power/supply/max17042_battery.c | 4 ++++
> 1 file changed, 4 insertions(+)
>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>


Best regards,
Krzysztof