Re: [PATCH 1/2] sysctl: introduce new proc handler proc_dobool

From: Kees Cook
Date: Thu Sep 16 2021 - 18:03:25 EST


On Tue, Aug 03, 2021 at 12:59:36PM +0200, Thomas Huth wrote:
> From: Jia He <hejianet@xxxxxxxxx>
>
> This is to let bool variable could be correctly displayed in
> big/little endian sysctl procfs. sizeof(bool) is arch dependent,
> proc_dobool should work in all arches.
>
> Suggested-by: Pan Xinhui <xinhui@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jia He <hejianet@xxxxxxxxx>

Hi! I apologize for the delay. Yes, this looks good to me; thanks!

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook