Re: [PATCH 2/3] PCI: Export find_pci_root_bus()

From: Marc Zyngier
Date: Mon Sep 20 2021 - 04:37:08 EST


On Mon, 20 Sep 2021 07:41:32 +0100,
Kishon Vijay Abraham I <kishon@xxxxxx> wrote:
>
> Export find_pci_root_bus() in order for other subsystems (like
> IRQCHIP) to find the root bus of a particual PCIe device.
>
> This is done in preparation for GIC ITS to walk the PCIe bus for
> calculating the total number of interrupt vectors that has to be
> supported by a specific GIC ITS device ID, specifically when
> "msi-map-mask" is populated in device tree.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---
> drivers/pci/host-bridge.c | 3 ++-
> include/linux/pci.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c
> index afa50b446567..4ec34d040c02 100644
> --- a/drivers/pci/host-bridge.c
> +++ b/drivers/pci/host-bridge.c
> @@ -9,13 +9,14 @@
>
> #include "pci.h"
>
> -static struct pci_bus *find_pci_root_bus(struct pci_bus *bus)
> +struct pci_bus *find_pci_root_bus(struct pci_bus *bus)
> {
> while (bus->parent)
> bus = bus->parent;
>
> return bus;
> }
> +EXPORT_SYMBOL_GPL(find_pci_root_bus);

There is no need for this export as the ITS cannot be made modular.

M.

--
Without deviation from the norm, progress is not possible.