Re: [net-next RFC PATCH 1/2] drivers: net: dsa: qca8k: add support for led config

From: Andrew Lunn
Date: Mon Sep 20 2021 - 15:21:25 EST


> Yes, can you point me to the discussion?

It has gone through many cycles :-(

The linux-led list is probably the better archive to look through, it
is a lot lower volume than netdev.

https://www.spinics.net/lists/linux-leds/msg18652.html

https://www.spinics.net/lists/linux-leds/msg18527.html


> I post this as RFC for this exact reason... I read somehwere that there
> was a discussion on how to implementd leds for switch but never ever
> found it.

Most of the discussion so far has been about PHY LEDs, where the PHY
driver controls the LEDs. However some Ethernet switches also have LED
controls, which are not part of the PHY. And then there are some MAC
drivers which control the PHY in firmware, and have firmware calls for
controlling the LEDs. We need a generic solution which scales across
all this. And it needs to work without DT, or at least, not block ACPI
being added later.

But progress is slow. I hope that the PHY use case will drive things
forward, get the ABI defined. We can then scale it out to include
switches, maybe with a bit of code refactoring.

Andrew