[PATCH v2 0/2] gpio: mlxbf2: Introduce proper interrupt handling

From: Asmaa Mnebhi
Date: Mon Sep 20 2021 - 17:24:46 EST


This is a follow up on a discussion regarding
proper handling of GPIO interrupts within the
gpio-mlxbf2.c driver.

Link to discussion:
https://lore.kernel.org/netdev/20210816115953.72533-7-andriy.shevchenko@xxxxxxxxxxxxxxx/T/

Patch 1 adds support to a GPIO IRQ handler in gpio-mlxbf2.c.
Patch 2 is a follow up removal of custom GPIO IRQ handling
from the mlxbf_gige driver and replacing it with a simple
IRQ request. The ACPI table for the mlxbf_gige driver is
responsible for instantiating the PHY GPIO interrupt via
GpioInt.

Andy Shevchenko, could you please review this patch series.

v2 vs. v1 patch:
All changes were made in gpio-mlxbf2.c
- removed unnecessary comments
- removed irq_ack as it is not needed
- removed irq_mask/irq_unmask as they are not invoked
- remove IRQ_TYPE_LEVEL* from mlxbf2_gpio_irq_set_type
since they are not supported

Asmaa Mnebhi (2):
gpio: mlxbf2: Introduce IRQ support
net: mellanox: mlxbf_gige: Replace non-standard interrupt handling

drivers/gpio/gpio-mlxbf2.c | 147 +++++++++++-
.../net/ethernet/mellanox/mlxbf_gige/Makefile | 1 -
.../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h | 12 -
.../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------
.../mellanox/mlxbf_gige/mlxbf_gige_main.c | 22 +-
5 files changed, 154 insertions(+), 240 deletions(-)
delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c

--
2.30.1