Re: [PATCH v2 0/2] x86/xen: simplify irq pvops

From: Peter Zijlstra
Date: Wed Sep 22 2021 - 08:50:12 EST


On Wed, Sep 22, 2021 at 12:31:00PM +0200, Juergen Gross wrote:
> The pvops function for Xen PV guests handling the interrupt flag are
> much more complex than needed.
>
> With the supported Xen hypervisor versions they can be simplified a
> lot, especially by removing the need for disabling preemption.
>
> Juergen Gross (2):
> x86/xen: remove xen_have_vcpu_info_placement flag
> x86/xen: switch initial pvops IRQ functions to dummy ones
>
> arch/x86/include/asm/paravirt_types.h | 2 +
> arch/x86/kernel/paravirt.c | 13 ++-
> arch/x86/xen/enlighten.c | 116 ++++++--------------------
> arch/x86/xen/enlighten_hvm.c | 6 +-
> arch/x86/xen/enlighten_pv.c | 28 ++-----
> arch/x86/xen/irq.c | 61 +-------------
> arch/x86/xen/smp.c | 24 ------
> arch/x86/xen/xen-ops.h | 4 +-
> 8 files changed, 53 insertions(+), 201 deletions(-)

That looks awesome, I'm totally in favour of deleting code :-)

Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>