Re: [RESEND PATCH 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration

From: Krzysztof Kozlowski
Date: Wed Sep 22 2021 - 10:10:30 EST


On 22/09/2021 15:52, Christophe Leroy wrote:
>
>
> Le 22/09/2021 à 10:44, Krzysztof Kozlowski a écrit :
>> g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c,
>> so it should have a declaration to fix W=1 warning:
>>
>> arch/powerpc/platforms/powermac/feature.c:1533:6:
>> error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes]
>
>
> While you are at it, can you clean it up completely, that is remove the
> declaration in arch/powerpc/platforms/powermac/smp.c ?
>

Sure, I'll send a v2. Thanks for pointing this out.


Best regards,
Krzysztof