RE: [PATCH] ath10k: Don't always treat modem stop events as crashes

From: pillair
Date: Fri Sep 24 2021 - 04:07:51 EST




> -----Original Message-----
> From: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Sent: Friday, September 24, 2021 1:30 PM
> To: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> Cc: pillair@xxxxxxxxxxxxxx; ath10k@xxxxxxxxxxxxxxxxxxx;
> govinds@xxxxxxxxxxxxxx; kuabhs@xxxxxxxxxxxx; linux-arm-
> msm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> youghand@xxxxxxxxxxxxxx
> Subject: Re: [PATCH] ath10k: Don't always treat modem stop events as
> crashes
>
> Stephen Boyd <swboyd@xxxxxxxxxxxx> writes:
>
> > Quoting pillair@xxxxxxxxxxxxxx (2021-09-21 22:35:34)
> >> On 9/5/21 4:04 PM, Stephen Boyd wrote:
> >>
> >> > +static int ath10k_snoc_modem_notify(struct notifier_block *nb,
> >> > +unsigned long
> > [...]
> >>
> >> > +
> >>
> >> > + return NOTIFY_OK;
> >>
> >> > +}
> >>
> >>
> >>
> >> Thanks for posting the patch. It would be preferable to use a
> >> different flag instead of ATH10K_SNOC_FLAG_UNREGISTERING,
> >>
> >> since we are not unloading the ath10k driver.
>
> Weird, I don't see pillair's email on patchwork[1] and not in the ath10k
list
> either. Was it sent as HTML or something?

Hi Kalle,
Yes, I replied via the "In-reply-to" from the patchworks[1] link.

Thanks,
Rakesh Pillai

>
> [1] https://patchwork.kernel.org/project/linux-
> wireless/patch/20210905210400.1157870-1-swboyd@xxxxxxxxxxxx/
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingp
> atches