Re: [PATCH 1/2] drm/vc4: hdmi: Check the device state in prepare()

From: Sudip Mukherjee
Date: Sun Sep 26 2021 - 17:25:33 EST


On Fri, Sep 24, 2021 at 2:55 PM Maxime Ripard <maxime@xxxxxxxxxx> wrote:
>
> Even though we already check that the encoder->crtc pointer is there
> during in startup(), which is part of the open() path in ASoC, nothing
> guarantees that our encoder state won't change between the time when we
> open the device and the time we prepare it.
>
> Move the sanity checks we do in startup() to a helper and call it from
> prepare().
>
> Fixes: 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec")
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>

Tested-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>


--
Regards
Sudip