Re: [PATCH] media: videobuf2: always set buffer vb2 pointer

From: Chen-Yu Tsai
Date: Tue Sep 28 2021 - 03:53:31 EST


On Tue, Sep 28, 2021 at 2:24 PM Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote:
>
> On Tue, Sep 28, 2021 at 2:16 PM Sergey Senozhatsky
> <senozhatsky@xxxxxxxxxxxx> wrote:
> >
> > We need to always link allocated vb2_dc_buf back to vb2_buffer because
> > we dereference vb2 in prepare() and finish() callbacks.
> >
> > Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>
>
> This fixes the breakage from the "videobuf2: support new noncontiguous DMA
> API" series on the RK3399 Scarlet if the ChromeOS patch that changes
> min_buffers_needed to 0 [1] is not applied.
>
> Since there are other in-tree drivers that have min_buffers_needed=0,
> I would recommend getting some more testing.

Seems I had a stale kernel when testing the min_buffers_needed=0 case.

Everythings works now.

Tested-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>