Re: [RFC PATCH 2/3] nSVM: introduce smv->nested.save to cache save area fields

From: Paolo Bonzini
Date: Wed Sep 29 2021 - 07:13:29 EST


On 29/09/21 00:23, Sean Christopherson wrote:
On a related topic, this would be a good opportunity to resolve the naming
discrepancies between VMX and SVM. VMX generally refers to vmcs12 as KVM's copy
of L1's VMCS, whereas SVM generally refers to vmcb12 as the "direct" mapping of
L1's VMCB. I'd prefer to go with VMX's terminology, i.e. rework nSVM to refer to
the copy as vmcb12, but I'm more than a bit biased since I've spent so much time
in nVMX,

I agree, and I think Emanuele's patches are a step in the right direction. Once we ensure that all state in svm->nested is cached vmcb12 content, we can get rid of vmcb12 pointers in the functions.

Paolo