[vsyrjala:dbuf_state_6 1246/1427] drivers/staging/rtl8712/rtl8712_xmit.c:249:6: warning: no previous prototype for 'r8712_construct_txaggr_cmd_desc'

From: kernel test robot
Date: Wed Sep 29 2021 - 20:12:13 EST

Next message: David Gow: "Re: [PATCH v2 1/5] gcc-plugins/structleak: add makefile var for disabling structleak"
Previous message: Gustavo A. R. Silva: "Re: linux-next: build failure after merge of the kspp-gustavo tree"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

tree: https://github.com/vsyrjala/linux.git dbuf_state_6
head: 92b057748a7ef272e28ca577829eb592a6bec099
commit: 34adbd7bf7daf25f291eed36b362eecb7f963645 [1246/1427] Revert "drm/i915: Don't select BROKEN"
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/vsyrjala/linux/commit/34adbd7bf7daf25f291eed36b362eecb7f963645
git remote add vsyrjala https://github.com/vsyrjala/linux.git
git fetch --no-tags vsyrjala dbuf_state_6
git checkout 34adbd7bf7daf25f291eed36b362eecb7f963645
# save the attached .config to linux build tree
make W=1 ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/staging/rtl8712/rtl8712_xmit.c:249:6: warning: no previous prototype for 'r8712_construct_txaggr_cmd_desc' [-Wmissing-prototypes]
249 | void r8712_construct_txaggr_cmd_desc(struct xmit_buf *pxmitbuf)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/rtl8712/rtl8712_xmit.c:265:6: warning: no previous prototype for 'r8712_construct_txaggr_cmd_hdr' [-Wmissing-prototypes]
265 | void r8712_construct_txaggr_cmd_hdr(struct xmit_buf *pxmitbuf)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/rtl8712/rtl8712_xmit.c:281:6: warning: no previous prototype for 'r8712_append_mpdu_unit' [-Wmissing-prototypes]
281 | void r8712_append_mpdu_unit(struct xmit_buf *pxmitbuf,
| ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/rtl8712/rtl8712_xmit.c:337:5: warning: no previous prototype for 'r8712_xmitframe_aggr_next' [-Wmissing-prototypes]
337 | u16 r8712_xmitframe_aggr_next(struct xmit_buf *pxmitbuf,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/rtl8712/rtl8712_xmit.c: In function 'r8712_dump_aggr_xframe':
drivers/staging/rtl8712/rtl8712_xmit.c:360:28: error: initialization of 'struct tx_desc *' from incompatible pointer type 'u8 *' {aka 'unsigned char *'} [-Werror=incompatible-pointer-types]
360 | struct tx_desc *ptxdesc = pxmitbuf->pbuf;
| ^~~~~~~~
drivers/staging/rtl8712/rtl8712_xmit.c: In function 'dump_xframe':
>> drivers/staging/rtl8712/rtl8712_xmit.c:692:6: warning: variable 'ff_hwaddr' set but not used [-Wunused-but-set-variable]
692 | u32 ff_hwaddr;
| ^~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/net/wireless/broadcom/b43/phy_lcn.c: In function 'b43_phy_lcn_rev0_baseband_init':
>> drivers/net/wireless/broadcom/b43/phy_lcn.c:244:3: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
244 | ; /* TODO */
| ^
drivers/net/wireless/broadcom/b43/phy_lcn.c: In function 'b43_phy_lcn_sense_setup':
>> drivers/net/wireless/broadcom/b43/phy_lcn.c:315:5: warning: variable 'tx_pwr_idx' set but not used [-Wunused-but-set-variable]
315 | u8 tx_pwr_idx;
| ^~~~~~~~~~
--
drivers/net/wireless/broadcom/b43/tables_phy_lcn.c: In function 'b43_phy_lcn_load_rfpower':
>> drivers/net/wireless/broadcom/b43/tables_phy_lcn.c:650:14: warning: variable 'rfgain' set but not used [-Wunused-but-set-variable]
650 | u32 bbmult, rfgain;
| ^~~~~~

vim +/r8712_construct_txaggr_cmd_desc +249 drivers/staging/rtl8712/rtl8712_xmit.c

2865d42c78a9121 Larry Finger 2010-08-20 247
93c55dda092c7ec Ali Bahar 2011-09-04 248 #ifdef CONFIG_R8712_TX_AGGR
e7df51e00828c81 Nishka Dasgupta 2019-08-09 @249 void r8712_construct_txaggr_cmd_desc(struct xmit_buf *pxmitbuf)
93c55dda092c7ec Ali Bahar 2011-09-04 250 {
93c55dda092c7ec Ali Bahar 2011-09-04 251 struct tx_desc *ptx_desc = (struct tx_desc *)pxmitbuf->pbuf;
93c55dda092c7ec Ali Bahar 2011-09-04 252
93c55dda092c7ec Ali Bahar 2011-09-04 253 /* Fill up TxCmd Descriptor according as USB FW Tx Aaggregation info.*/
93c55dda092c7ec Ali Bahar 2011-09-04 254 /* dw0 */
93c55dda092c7ec Ali Bahar 2011-09-04 255 ptx_desc->txdw0 = cpu_to_le32(CMD_HDR_SZ & 0xffff);
93c55dda092c7ec Ali Bahar 2011-09-04 256 ptx_desc->txdw0 |=
4ef2de5ae0377bc Luis de Bethencourt 2015-10-19 257 cpu_to_le32(((TXDESC_SIZE + OFFSET_SZ) << OFFSET_SHT) &
4ef2de5ae0377bc Luis de Bethencourt 2015-10-19 258 0x00ff0000);
93c55dda092c7ec Ali Bahar 2011-09-04 259 ptx_desc->txdw0 |= cpu_to_le32(OWN | FSG | LSG);
93c55dda092c7ec Ali Bahar 2011-09-04 260
93c55dda092c7ec Ali Bahar 2011-09-04 261 /* dw1 */
93c55dda092c7ec Ali Bahar 2011-09-04 262 ptx_desc->txdw1 |= cpu_to_le32((0x13 << QSEL_SHT) & 0x00001f00);
93c55dda092c7ec Ali Bahar 2011-09-04 263 }
93c55dda092c7ec Ali Bahar 2011-09-04 264
70deda9dfa6678b Nishka Dasgupta 2019-08-09 @265 void r8712_construct_txaggr_cmd_hdr(struct xmit_buf *pxmitbuf)
93c55dda092c7ec Ali Bahar 2011-09-04 266 {
93c55dda092c7ec Ali Bahar 2011-09-04 267 struct xmit_frame *pxmitframe = (struct xmit_frame *)
93c55dda092c7ec Ali Bahar 2011-09-04 268 pxmitbuf->priv_data;
93c55dda092c7ec Ali Bahar 2011-09-04 269 struct _adapter *padapter = pxmitframe->padapter;
27903f9f6b6ca13 Branden Bonaby 2019-03-26 270 struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
93c55dda092c7ec Ali Bahar 2011-09-04 271 struct cmd_hdr *pcmd_hdr = (struct cmd_hdr *)
93c55dda092c7ec Ali Bahar 2011-09-04 272 (pxmitbuf->pbuf + TXDESC_SIZE);
93c55dda092c7ec Ali Bahar 2011-09-04 273
93c55dda092c7ec Ali Bahar 2011-09-04 274 /* Fill up Cmd Header for USB FW Tx Aggregation.*/
93c55dda092c7ec Ali Bahar 2011-09-04 275 /* dw0 */
93c55dda092c7ec Ali Bahar 2011-09-04 276 pcmd_hdr->cmd_dw0 = cpu_to_le32((GEN_CMD_CODE(_AMSDU_TO_AMPDU) << 16) |
93c55dda092c7ec Ali Bahar 2011-09-04 277 (pcmdpriv->cmd_seq << 24));
93c55dda092c7ec Ali Bahar 2011-09-04 278 pcmdpriv->cmd_seq++;
93c55dda092c7ec Ali Bahar 2011-09-04 279 }
93c55dda092c7ec Ali Bahar 2011-09-04 280
bc6132f141b75ea Nishka Dasgupta 2019-08-13 @281 void r8712_append_mpdu_unit(struct xmit_buf *pxmitbuf,
93c55dda092c7ec Ali Bahar 2011-09-04 282 struct xmit_frame *pxmitframe)
93c55dda092c7ec Ali Bahar 2011-09-04 283 {
93c55dda092c7ec Ali Bahar 2011-09-04 284 struct _adapter *padapter = pxmitframe->padapter;
93c55dda092c7ec Ali Bahar 2011-09-04 285 struct tx_desc *ptx_desc = (struct tx_desc *)pxmitbuf->pbuf;
93c55dda092c7ec Ali Bahar 2011-09-04 286 int last_txcmdsz = 0;
93c55dda092c7ec Ali Bahar 2011-09-04 287 int padding_sz = 0;
93c55dda092c7ec Ali Bahar 2011-09-04 288
dec9fcd03284c22 Joseph Wright 2017-01-24 289 /* 802.3->802.11 converter */
93c55dda092c7ec Ali Bahar 2011-09-04 290 r8712_xmitframe_coalesce(padapter, pxmitframe->pkt, pxmitframe);
93c55dda092c7ec Ali Bahar 2011-09-04 291 /* free skb struct */
93c55dda092c7ec Ali Bahar 2011-09-04 292 r8712_xmit_complete(padapter, pxmitframe);
93c55dda092c7ec Ali Bahar 2011-09-04 293 if (pxmitframe->attrib.ether_type != 0x0806) {
93c55dda092c7ec Ali Bahar 2011-09-04 294 if ((pxmitframe->attrib.ether_type != 0x888e) &&
93c55dda092c7ec Ali Bahar 2011-09-04 295 (pxmitframe->attrib.dhcp_pkt != 1)) {
93c55dda092c7ec Ali Bahar 2011-09-04 296 r8712_issue_addbareq_cmd(padapter,
93c55dda092c7ec Ali Bahar 2011-09-04 297 pxmitframe->attrib.priority);
93c55dda092c7ec Ali Bahar 2011-09-04 298 }
93c55dda092c7ec Ali Bahar 2011-09-04 299 }
93c55dda092c7ec Ali Bahar 2011-09-04 300 pxmitframe->last[0] = 1;
93c55dda092c7ec Ali Bahar 2011-09-04 301 update_txdesc(pxmitframe, (uint *)(pxmitframe->buf_addr),
93c55dda092c7ec Ali Bahar 2011-09-04 302 pxmitframe->attrib.last_txcmdsz);
93c55dda092c7ec Ali Bahar 2011-09-04 303 /*padding zero */
93c55dda092c7ec Ali Bahar 2011-09-04 304 last_txcmdsz = pxmitframe->attrib.last_txcmdsz;
93c55dda092c7ec Ali Bahar 2011-09-04 305 padding_sz = (8 - (last_txcmdsz % 8));
93c55dda092c7ec Ali Bahar 2011-09-04 306 if ((last_txcmdsz % 8) != 0) {
93c55dda092c7ec Ali Bahar 2011-09-04 307 int i;
02a29d2d9209ad2 Tapasweni Pathak 2014-09-24 308
93c55dda092c7ec Ali Bahar 2011-09-04 309 for (i = 0; i < padding_sz; i++)
4ef2de5ae0377bc Luis de Bethencourt 2015-10-19 310 *(pxmitframe->buf_addr + TXDESC_SIZE + last_txcmdsz +
4ef2de5ae0377bc Luis de Bethencourt 2015-10-19 311 i) = 0;
93c55dda092c7ec Ali Bahar 2011-09-04 312 }
93c55dda092c7ec Ali Bahar 2011-09-04 313 /* Add the new mpdu's length */
93c55dda092c7ec Ali Bahar 2011-09-04 314 ptx_desc->txdw0 = cpu_to_le32((ptx_desc->txdw0 & 0xffff0000) |
93c55dda092c7ec Ali Bahar 2011-09-04 315 ((ptx_desc->txdw0 & 0x0000ffff) +
4ef2de5ae0377bc Luis de Bethencourt 2015-10-19 316 ((TXDESC_SIZE + last_txcmdsz + padding_sz) &
4ef2de5ae0377bc Luis de Bethencourt 2015-10-19 317 0x0000ffff)));
93c55dda092c7ec Ali Bahar 2011-09-04 318 }
93c55dda092c7ec Ali Bahar 2011-09-04 319
93c55dda092c7ec Ali Bahar 2011-09-04 320
b849e9a4a09f349 Nishka Dasgupta 2019-08-13 321 void r8712_xmitframe_aggr_1st(struct xmit_buf *pxmitbuf,
93c55dda092c7ec Ali Bahar 2011-09-04 322 struct xmit_frame *pxmitframe)
93c55dda092c7ec Ali Bahar 2011-09-04 323 {
69e98df78271a71 Carlos E. Garcia 2015-04-24 324 /* linux complete context doesn't need to protect */
93c55dda092c7ec Ali Bahar 2011-09-04 325 pxmitframe->pxmitbuf = pxmitbuf;
93c55dda092c7ec Ali Bahar 2011-09-04 326 pxmitbuf->priv_data = pxmitframe;
93c55dda092c7ec Ali Bahar 2011-09-04 327 pxmitframe->pxmit_urb[0] = pxmitbuf->pxmit_urb[0];
93c55dda092c7ec Ali Bahar 2011-09-04 328 /* buffer addr assoc */
93c55dda092c7ec Ali Bahar 2011-09-04 329 pxmitframe->buf_addr = pxmitbuf->pbuf + TXDESC_SIZE + CMD_HDR_SZ;
93c55dda092c7ec Ali Bahar 2011-09-04 330 /*RTL8712_DMA_H2CCMD */
93c55dda092c7ec Ali Bahar 2011-09-04 331 r8712_construct_txaggr_cmd_desc(pxmitbuf);
93c55dda092c7ec Ali Bahar 2011-09-04 332 r8712_construct_txaggr_cmd_hdr(pxmitbuf);
bc6132f141b75ea Nishka Dasgupta 2019-08-13 333 r8712_append_mpdu_unit(pxmitbuf, pxmitframe);
93c55dda092c7ec Ali Bahar 2011-09-04 334 pxmitbuf->aggr_nr = 1;
93c55dda092c7ec Ali Bahar 2011-09-04 335 }
93c55dda092c7ec Ali Bahar 2011-09-04 336
93c55dda092c7ec Ali Bahar 2011-09-04 @337 u16 r8712_xmitframe_aggr_next(struct xmit_buf *pxmitbuf,
93c55dda092c7ec Ali Bahar 2011-09-04 338 struct xmit_frame *pxmitframe)
93c55dda092c7ec Ali Bahar 2011-09-04 339 {
93c55dda092c7ec Ali Bahar 2011-09-04 340 pxmitframe->pxmitbuf = pxmitbuf;
93c55dda092c7ec Ali Bahar 2011-09-04 341 pxmitbuf->priv_data = pxmitframe;
93c55dda092c7ec Ali Bahar 2011-09-04 342 pxmitframe->pxmit_urb[0] = pxmitbuf->pxmit_urb[0];
93c55dda092c7ec Ali Bahar 2011-09-04 343 /* buffer addr assoc */
93c55dda092c7ec Ali Bahar 2011-09-04 344 pxmitframe->buf_addr = pxmitbuf->pbuf + TXDESC_SIZE +
93c55dda092c7ec Ali Bahar 2011-09-04 345 (((struct tx_desc *)pxmitbuf->pbuf)->txdw0 & 0x0000ffff);
bc6132f141b75ea Nishka Dasgupta 2019-08-13 346 r8712_append_mpdu_unit(pxmitbuf, pxmitframe);
93c55dda092c7ec Ali Bahar 2011-09-04 347 r8712_free_xmitframe_ex(&pxmitframe->padapter->xmitpriv,
93c55dda092c7ec Ali Bahar 2011-09-04 348 pxmitframe);
93c55dda092c7ec Ali Bahar 2011-09-04 349 pxmitbuf->aggr_nr++;
93c55dda092c7ec Ali Bahar 2011-09-04 350
93c55dda092c7ec Ali Bahar 2011-09-04 351 return TXDESC_SIZE +
93c55dda092c7ec Ali Bahar 2011-09-04 352 (((struct tx_desc *)pxmitbuf->pbuf)->txdw0 & 0x0000ffff);
93c55dda092c7ec Ali Bahar 2011-09-04 353 }
93c55dda092c7ec Ali Bahar 2011-09-04 354

:::::: The code at line 249 was first introduced by commit
:::::: e7df51e00828c81fe22225da92223eb6a233e91e staging: rtl8712: r8712_construct_txaggr_cmd_desc(): Change return type

:::::: TO: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

Next message: David Gow: "Re: [PATCH v2 1/5] gcc-plugins/structleak: add makefile var for disabling structleak"
Previous message: Gustavo A. R. Silva: "Re: linux-next: build failure after merge of the kspp-gustavo tree"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]