Re: [PATCH] clocksource/drivers/timer-ti-dm: Select TIMER_OF

From: Tony Lindgren
Date: Thu Sep 30 2021 - 04:49:49 EST


* Kees Cook <keescook@xxxxxxxxxxxx> [210828 17:58]:
> When building OMAP_DM_TIMER without TIMER_OF, there are orphan sections
> due to the use of TIMER_OF_DELCARE() without CONFIG_TIMER_OF. Select
> CONFIG_TIMER_OF when enaling OMAP_DM_TIMER:
>
> arm-linux-gnueabi-ld: warning: orphan section `__timer_of_table' from `drivers/clocksource/timer-ti-dm-systimer.o' being placed in section `__timer_of_table'
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Link: https://lore.kernel.org/lkml/202108282255.tkdt4ani-lkp@xxxxxxxxx/
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Cc: Keerthy <j-keerthy@xxxxxx>
> Cc: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>
> Cc: Ladislav Michl <ladis@xxxxxxxxxxxxxx>
> Cc: Grygorii Strashko <grygorii.strashko@xxxxxx>
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support")
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

Sorry for the delay, I just noticed I never replied earlier:

Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>

> ---
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 0f5e3983951a..08f8cb944a2a 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -24,6 +24,7 @@ config I8253_LOCK
>
> config OMAP_DM_TIMER
> bool
> + select TIMER_OF
>
> config CLKBLD_I8253
> def_bool y if CLKSRC_I8253 || CLKEVT_I8253 || I8253_LOCK
> --
> 2.30.2
>