Re: [PATCH] soundwire: qcom: add debugfs entry for soundwire register dump

[Srinivas Kandagatla]

On 01/10/2021 05:20, Vinod Koul wrote:
> HI Srini,
>
> On 07-09-21, 11:56, Srinivas Kandagatla wrote:
> > +#ifdef CONFIG_DEBUG_FS
> > +static int swrm_reg_show(struct seq_file *s_file, void *data)
> > +{
> > +	struct qcom_swrm_ctrl *swrm = s_file->private;
> > +	int reg, reg_val;
> > +
> > +	for (reg = 0; reg <= SWR_MSTR_MAX_REG_ADDR; reg += 4) {
> > +		swrm->reg_read(swrm, reg, &reg_val);
>
> Why not use regmap_read here, that would avoid reading from the bus when
> we already have the values...

Sorry for such late reply.
But these are controller registers which are not exposed as regmaps in 
mmio cases.


> Second make sure later when pm_runtime support is added, this take a
> reference ..
Yes, Am currently working on runtime pm support, I will make sure that 
this is take care.

--srini
> Thanks