Re: [PATCH v3] scsi: core: Fix shost->cmd_per_lun calculation in scsi_add_host_with_dma()

From: John Garry
Date: Fri Oct 08 2021 - 07:58:02 EST


On 08/10/2021 05:35, Dexuan Cui wrote:
After commit ea2f0f77538c, a 416-CPU VM running on Hyper-V hangs during
boot because the hv_storvsc driver sets scsi_driver.can_queue to an "int"
value that exceeds SHRT_MAX, and hence scsi_add_host_with_dma() sets
shost->cmd_per_lun to a negative "short" value.

Use min_t(int, ...) to fix the issue.

Fixes: ea2f0f77538c ("scsi: core: Cap scsi_host cmd_per_lun at can_queue")
Cc:stable@xxxxxxxxxxxxxxx
Signed-off-by: Dexuan Cui<decui@xxxxxxxxxxxxx>
Reviewed-by: Haiyang Zhang<haiyangz@xxxxxxxxxxxxx>
Reviewed-by: Ming Lei<ming.lei@xxxxxxxxxx>

Reviewed-by: John Garry <john.garry@xxxxxxxxxx>

thanks