Re: [PATCH v3 2/2] ASoC: rt9120: Add rt9210 audio amplifier support

From: Mark Brown
Date: Fri Oct 08 2021 - 08:51:31 EST


On Fri, Oct 08, 2021 at 12:50:12PM +0800, cy_huang wrote:

> +static const struct snd_kcontrol_new rt9120_snd_controls[] = {
> + SOC_SINGLE_TLV("MS Volume", RT9120_REG_MSVOL, 0, 2047, 1, digital_gain),
> + SOC_SINGLE("SPK Gain", RT9120_REG_SPKGAIN, 0, 7, 0),

Volume controls should end in Volume even if they don't have TLV
information so applications know how to render them. I'll fix
this up as I apply.

Attachment: signature.asc
Description: PGP signature