Re: [PATCH v2 2/3] dt-bindings: iio: io-channel-mux: Add property for settle time

From: Vincent Whitchurch
Date: Fri Oct 08 2021 - 09:56:15 EST


On Fri, Oct 08, 2021 at 04:46:12AM +0200, Rob Herring wrote:
> On Thu, 07 Oct 2021 15:46:40 +0200, Vincent Whitchurch wrote:
> > Hardware may require some time for the muxed analog signals to settle
> > after the muxing is changed. Allow this time to be specified in the
> > devicetree.
> >
> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>
> > ---
> > .../devicetree/bindings/iio/multiplexer/io-channel-mux.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.

Yes, these are not new warnings.

> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1537724
>
>
> adc0mux: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dt.yaml
>
> adc10mux: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dt.yaml
[...]

I think the fix for these is to add a "#io-channel-cells": const 1 to
the schema.

> envelope-detector-mux: channels: ['', '', 'sync-1', 'in', 'out', 'sync-2', 'sys-reg', 'ana-reg'] has non-unique elements
> arch/arm/boot/dts/at91-tse850-3.dt.yaml

This one looks like an error in that particular devicetree.