Re: [PATCH v2 2/2] PCI: hv: Support for Hyper-V vPCI for ARM64

From: Bjorn Helgaas
Date: Fri Oct 08 2021 - 15:23:03 EST


Subject line should start with a verb telling us what this does.

On Fri, Oct 08, 2021 at 05:21:29PM +0000, Sunil Muthuswamy wrote:
> This patch adds support for Hyper-V vPCI by adding a PCI MSI
> IRQ domain specific to Hyper-V that is based on SPIs. The IRQ
> domain parents itself to the arch GIC IRQ domain for basic
> vector management.

Same "This patch adds ..." comment as for patch 1/2. You could say
something like "Add support ...". It would also be good to include
"ARM64" since I think that's the point here.

> + /* Delivery mode: Fixed */
> + *delivery_mode = 0;

Why not APIC_DELIVERY_MODE_FIXED as you used for x86?

Bjorn