Re: [net-next PATCH v2 13/15] dt-bindings: net: dsa: qca8k: document open drain binding

From: Andrew Lunn
Date: Sat Oct 09 2021 - 13:21:00 EST


On Fri, Oct 08, 2021 at 02:22:23AM +0200, Ansuel Smith wrote:
> Document new binding qca,power_on_sel used to enable Power-on-strapping
> select reg and qca,led_open_drain to set led to open drain mode.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/net/dsa/qca8k.txt | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> index b9cccb657373..9fb4db65907e 100644
> --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> @@ -13,6 +13,17 @@ Required properties:
> Optional properties:
>
> - reset-gpios: GPIO to be used to reset the whole device
> +- qca,ignore-power-on-sel: Ignore power on pin strapping to configure led open
> + drain or eeprom presence.

So strapping is only used for LEDs and EEPROM presence? Nothing else?
Seems link MAC0/MAC6 swap would be a good candidate for strapping?

I just want to make it clear that if you select this option, you need
to take care of X, Y and Z in DT.

Andrew