Re: [PATCH] ASoC: simple-card: Fill in driver name

[Jaroslav Kysela]

On 10. 10. 21 9:47, Diederik de Haas wrote:
> On Tuesday, 22 June 2021 10:27:09 CEST Guido Günther wrote:
> > alsa-ucm groups by driver name so fill that in as well. Otherwise the
> > presented information is redundant and doesn't reflect the used
> > driver. We can't just use 'asoc-simple-card' since the driver name is
> > restricted to 15 characters.
> >
> > Before:
> >
> >   # cat /proc/asound/cards
> >   0 [Devkit         ]: Librem_5_Devkit - Librem 5 Devkit
> >                        Librem 5 Devkit
> > After:
> >
> >   0 [Devkit         ]: simple-card - Librem 5 Devkit
> >                        Librem 5 Devkit
> >
> > Signed-off-by: Guido Günther <agx@xxxxxxxxxxx>
> > ---
> > This came out of a discussion about adding alsa-ucm profiles for the
> > Librem 5 Devkit at https://github.com/alsa-project/alsa-ucm-conf/pull/102
> >
> >   sound/soc/generic/simple-card.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/soc/generic/simple-card.c
> > b/sound/soc/generic/simple-card.c index 0015f534d42d..a3a7990b5cb6 100644
> > --- a/sound/soc/generic/simple-card.c
> > +++ b/sound/soc/generic/simple-card.c
> > @@ -621,6 +621,7 @@ static int asoc_simple_probe(struct platform_device
> > *pdev) card->owner		= THIS_MODULE;
> >   	card->dev		= dev;
> >   	card->probe		= simple_soc_probe;
> > +	card->driver_name       = "simple-card";
> >
> >   	li = devm_kzalloc(dev, sizeof(*li), GFP_KERNEL);
> >   	if (!li)
>
> Unfortunately this change broke multichannel audio on my Rock64 device running
> Debian. My Rock64 is connected to my AVR (Pioneer SC-1224) via a HDMI cable.

This looks like an user space configuration problem. You should check, if a PA 
profile or an UCM configuration is used (in the PA debug log).

						Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.