Re: [PATCH] ethernet: Remove redundant 'flush_workqueue()' calls

[Leon Romanovsky]

On Sun, Oct 10, 2021 at 09:01:32AM +0200, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> This was generated with coccinelle:
> 
> @@
> expression E;
> @@
> - 	flush_workqueue(E);
> 	destroy_workqueue(E);
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/amd/xgbe/xgbe-drv.c                 | 2 --
>  drivers/net/ethernet/brocade/bna/bnad.c                  | 1 -
>  drivers/net/ethernet/cavium/liquidio/lio_core.c          | 1 -
>  drivers/net/ethernet/emulex/benet/be_main.c              | 1 -
>  drivers/net/ethernet/marvell/octeontx2/af/cgx.c          | 1 -
>  drivers/net/ethernet/marvell/octeontx2/af/rvu.c          | 2 --
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c      | 1 -
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c     | 1 -
>  drivers/net/ethernet/mellanox/mlx4/cmd.c                 | 2 --
>  drivers/net/ethernet/mellanox/mlx4/en_main.c             | 1 -
>  drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 1 -
>  drivers/net/ethernet/qlogic/qed/qed_sriov.c              | 1 -
>  12 files changed, 15 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx> #mlx*