Re: [net-next PATCH v4 03/13] dt-bindings: net: dsa: qca8k: Add MAC swap and clock phase properties

[Ansuel Smith]

On Sun, Oct 10, 2021 at 03:07:28PM +0300, Vladimir Oltean wrote:
> On Sun, Oct 10, 2021 at 01:15:46PM +0200, Ansuel Smith wrote:
> > Add names and descriptions of additional PORT0_PAD_CTRL properties.
> > qca,sgmii-(rx|tx)clk-falling-edge are for setting the respective clock
> > phase to failling edge.
> > 
> > Signed-off-by: Matthew Hagan <mnhagan88@xxxxxxxxx>
> > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> > index 8c73f67c43ca..cc214e655442 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> > @@ -37,6 +37,10 @@ A CPU port node has the following optional node:
> >                            managed entity. See
> >                            Documentation/devicetree/bindings/net/fixed-link.txt
> >                            for details.
> > +- qca,sgmii-rxclk-falling-edge: Set the receive clock phase to falling edge.
> > +                                Mostly used in qca8327 with CPU port 0 set to
> > +                                sgmii.
> > +- qca,sgmii-txclk-falling-edge: Set the transmit clock phase to falling edge.
> >  
> >  For QCA8K the 'fixed-link' sub-node supports only the following properties:
> >  
> > -- 
> > 2.32.0
> > 
> 
> Must first document, then use.
> Also, would you care converting qca8k.txt to qca8k.yaml?

Ow ok, will swap alle the patch.
About converting... Hard task will try but it will be a nightmare. Sad
me.

-- 
	Ansuel