Re: [PATCH v4 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI.

From: Guenter Roeck
Date: Sun Oct 10 2021 - 19:58:13 EST


On 10/10/21 3:09 PM, Eugene Shalygin wrote:
Changes in v4:
- implement wmi driver instead platform driver.

There are many ASUS boards where the required function is present but
does nothing. With the WMI module alias the driver will be attempted
to load for those boards (and rejected by the _probe() function). Is
it a good thing?


Drivers failing probe with -ENODEV (presumably here because dmi_check_system()
does not find a match) is pretty normal. Board detection with the WMI driver
seems much more straightforward/simple compared the previous version with
the platform driver. Maybe I am missing something, but I don't see a
problem with the WMI approach.

Guenter