Re: [PATCH] cdrom: docs: reformat table in Documentation/userspace-api/ioctl/cdrom.rst

From: Jens Axboe
Date: Sun Oct 10 2021 - 21:36:19 EST


On 10/10/21 6:18 PM, Phillip Potter wrote:
> On Thu, Oct 07, 2021 at 04:34:13PM -0700, Randy Dunlap wrote:
>> On 10/7/21 4:17 PM, Phillip Potter wrote:
>>> Add extra space to the first column of ioctl values table, and also realign
>>> the text in the second column, to fix a documentation build warning
>>> introduced by: commit 67f1e027c270 ("drivers/cdrom: improved ioctl for
>>> media change detection")
>>>
>>> Suggested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>> Fixes: 67f1e027c270 ("drivers/cdrom: improved ioctl for media change detection")
>>> Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
>>
>> Looks good. Thanks.
>>
>> Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>
>>
>>> ---
>>> Documentation/userspace-api/ioctl/cdrom.rst | 116 ++++++++++----------
>>> 1 file changed, 58 insertions(+), 58 deletions(-)
>>>
>>> diff --git a/Documentation/userspace-api/ioctl/cdrom.rst b/Documentation/userspace-api/ioctl/cdrom.rst
>>> index bac5bbf93ca0..682948fc88a3 100644
>>> --- a/Documentation/userspace-api/ioctl/cdrom.rst
>>> +++ b/Documentation/userspace-api/ioctl/cdrom.rst
>>
>>
>>
>> --
>> ~Randy
>
> Thank you for the review Randy.

Applied.

--
Jens Axboe