Re: [PATCH v3] mm: mmap_lock: remove "\n" in TP_printk and use DECLARE_EVENT_CLASS

[Steven Rostedt]

On Mon, 11 Oct 2021 10:11:24 +0800
Gang Li <ligang.bdlg@xxxxxxxxxxxxx> wrote:

> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
> 
> By using DECLARE_EVENT_CLASS and TRACE_EVENT_FN, we can save a lot
> of space from duplicate code.

Why did you send this? It should be two patches, not one. The rule is,
every commit does one thing. Now you made this patch do two.

Andrew already pulled in the other two patches. I don't think this one
is appropriate, and should be discarded.

-- Steve


> 
> Signed-off-by: Gang Li <ligang.bdlg@xxxxxxxxxxxxx>