Re: [PATCH 0/2] tpm: use SM3 instead of SM3_256

From: Tianjia Zhang
Date: Mon Oct 11 2021 - 03:02:34 EST


Hi James,

On 10/9/21 9:29 PM, James Bottomley wrote:
On Sat, 2021-10-09 at 21:08 +0800, Tianjia Zhang wrote:
According to https://tools.ietf.org/id/draft-oscca-cfrg-sm3-01.html,
SM3 always produces a 256-bit hash value and there are no plans for
other length development, so there is no ambiguity in the name of
sm3.

For the TPM we're following the TPM Library specification

https://trustedcomputinggroup.org/resource/tpm-library-specification/

Which is very clear: the algorithm name is TPM_ALG_SM3_256

We're using sm3 as our exposed name because that's what linux crypto
uses, so there should be no problem in what the end user sees, but
changing to non standard TPM definitions is only going to cause
confusion at the kernel level.

James


Thanks for your attention. This is really tricky. I will contact trustedcomputinggroup first and give some suggestions, It would be best if a more standard algorithm name can be used from the source of the specification.

I think the macro definition of the crypto directory can remove this suffix first, that is, apply patch 1. What's your opinion?

Best regards,
Tianjia