Re: [PATCH v1] MIPS: Malta: fix alignment of the devicetree buffer

From: Oleksij Rempel
Date: Mon Oct 11 2021 - 03:16:08 EST


On Sun, Oct 10, 2021 at 11:58:24AM +0200, Maciej W. Rozycki wrote:
> On Thu, 2 Sep 2021, Marc Kleine-Budde wrote:
>
> > > > Starting with following patch MIPS Malta is not able to boot:
> > > > | commit 79edff12060fe7772af08607eff50c0e2486c5ba
> > > > | Author: Rob Herring <robh@xxxxxxxxxx>
> > > > | scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9
> >
> > If the above patch broke malts, IMHO the fixes tag should be:
> >
> > Fixes: 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")
>
> It's not clear either from this patch description or from the commit
> referred what the actual *purpose* of the alignment check is and therefore
> I think it's hard to say which of the two commits needs to be indicated as
> the offender. Without further data I tend to agree it's 79edff12060f that
> ought to be referred, being the immediate cause of the regression, as
> things obviously worked before, for 5+ years.

This patch was already taken. Do I need to do any thing?

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |