Re: linux-next: build failure after merge of the amdgpu tree

From: Simon Ser
Date: Mon Oct 11 2021 - 04:22:38 EST


On Monday, October 11th, 2021 at 10:01, Christoph Hellwig <hch@xxxxxx> wrote:

> On Mon, Oct 11, 2021 at 07:57:17AM +0000, Simon Ser wrote:
> > No, we can't have a "I_AM_NOT_BROKEN" ioctl for each and every uAPI mis-use.
> > User-space detection has been determined to be the best course of action.
>
> If your API addition breaks userspace, yes you need an add-in.

It's not an API addition. It's a ChromeOS fix that breaks my user-space.

> With your completely broken change you cement in a mapping of an executable
> name to map to what you consider a "bug" without any way to fix it up.

If that's the only concern, it'd be very easy to add a CAP_ATOMIC >= 2 check
like we have for Xorg. This would make it so ChromeOS can eventually opt-out
of the quirk.