Re: [PATCH] locking/ww_mutex: set ret variable on failure

[Will Deacon]

On Mon, Sep 27, 2021 at 07:57:56AM -0700, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
> 
> Building with clang 13 produces this error
> test-ww_mutex.c:138:7: error: variable 'ret' is used
>   uninitialized whenever 'if' condition is true
>   [-Werror,-Wsometimes-uninitialized]
>                 if (!ww_mutex_trylock(&mutex, &ctx)) {
>                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> On this failure set ret to -EINVAL as is similarly done
> in the function.
> 
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
>  kernel/locking/test-ww_mutex.c | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Will Deacon <will@xxxxxxxxxx>

Will