Re: [PATCH] staging: rtl8723bs: core: simplify the if condition
From: Dan Carpenter
Date: Mon Oct 11 2021 - 08:10:05 EST
You didn't compile test the patch.
On Sat, Oct 09, 2021 at 11:30:53AM +0530, Saurav Girepunje wrote:
> if psta is NULL, function is returning with fail. On next if condition
> again checking if psta is not a NULL. Remove multiple if condition check.
>
I don't think this is an accurate description of what the patch does.
> Function is already using goto exit statement to exit.Replace multiple
> return with goto exit statement.
No. Do nothing labels only hurt readability and introduce "forgot to
set the error code bugs."
regards,
dan carpenter