Re: [PATCH v3 4/8] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY

From: Jakub Kicinski
Date: Mon Oct 11 2021 - 11:25:04 EST


On Mon, 11 Oct 2021 17:22:11 +0300 alexandru.tachici@xxxxxxxxxx wrote:
> +/**
> + * struct adin_priv - ADIN PHY driver private data
> + * tx_level_2v4_able set if the PHY supports 2.4V TX levels (10BASE-T1L)
> + * tx_level_2v4 set if the PHY requests 2.4V TX levels (10BASE-T1L)
> + * tx_level_prop_present set if the TX level is specified in DT
> + */

This is not correct kdoc format. Should be

* @member: description

scripts/kernel-doc -none is your friend:

drivers/net/phy/adin1100.c:44: warning: Function parameter or member 'tx_level_2v4_able' not described in 'adin_priv'
drivers/net/phy/adin1100.c:44: warning: Function parameter or member 'tx_level_2v4' not described in 'adin_priv'
drivers/net/phy/adin1100.c:44: warning: Function parameter or member 'tx_level_prop_present' not described in 'adin_priv'