Re: [PATCH v2] staging: rtl8723bs: os_dep: simplify the return statement.

From: Saurav Girepunje
Date: Mon Oct 11 2021 - 14:28:09 EST




On 11/10/21 6:00 pm, Dan Carpenter wrote:
> On Sun, Oct 10, 2021 at 10:36:05AM +0530, Saurav Girepunje wrote:
>> Remove the unneeded and redundant check of variable on goto out.
>> Simplify the return using multiple goto label to avoid
>> unneeded check.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx>
>
> No, sorry but the goto bunny hops, the pointless do-nothing gotos, and
> the come from labels are all terrible.
>
> regards,
> dan carpenter
>

Thanks dan for your input.

Regards,
Saurav