Re: [PATCH v10 02/11] x86/tdx: Introduce INTEL_TDX_GUEST config option

[Andi Kleen]

On 10/11/2021 11:19 AM, Josh Poimboeuf wrote:
> On Fri, Oct 08, 2021 at 10:37:38PM -0700, Kuppuswamy Sathyanarayanan wrote:
> > +config INTEL_TDX_GUEST
> > +	bool "Intel Trusted Domain Extensions (TDX) Guest Support"
> > +	depends on X86_64 && CPU_SUP_INTEL && PARAVIRT
> > +	depends on SECURITY
> > +	depends on X86_X2APIC
> > +	help
> > +	  Provide support for running in a trusted domain on Intel processors
> > +	  equipped with Trusted Domain Extensions. TDX is a Intel technology
> > +	  that extends VMX and Memory Encryption with a new kind of virtual
> > +	  machine guest called Trust Domain (TD). A TD is designed to run in
> > +	  a CPU mode that protects the confidentiality of TD memory contents
> > +	  and the TD’s CPU state from other software, including VMM. TDX guest
> > +	  uses virtual X2APIC for interrupt management.
> Why does it depend on SECURITY?  It should at least be explained in the
> commit message.

It can be dropped, it was only needed in an earlier version that used a LSM.

-Andi

>