Re: [PATCH rdma-next] RDMA/mlx4: Return missed an error if device doesn't support steering

From: Jason Gunthorpe
Date: Tue Oct 12 2021 - 12:24:53 EST


On Tue, Oct 12, 2021 at 10:28:43AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> The error flow fixed in this patch is not possible because all kernel
> users of create QP interface check that device supports steering before
> set IB_QP_CREATE_NETIF_QP flag.
>
> Fixes: c1c98501121e ("IB/mlx4: Add support for steerable IB UD QPs")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/mlx4/qp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Applied to for-next, thanks

Jason