Re: [PATCH v2] iio: core: fix double free in iio_device_unregister_sysfs()

From: Andy Shevchenko
Date: Tue Oct 12 2021 - 13:28:48 EST


On Mon, Oct 11, 2021 at 12:12 PM Yang Yingliang
<yangyingliang@xxxxxxxxxx> wrote:
>
> I got the double free report:
>
> BUG: KASAN: double-free or invalid-free in kfree+0xce/0x390
>
> CPU: 0 PID: 359 Comm: xrun Tainted: G W 5.15.0-rc3-00109-g4dfd49fafc4d-dirty #474 523b7f3c65c42247635e2ac04a95f61f9f36678d
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014
> Call Trace:
> dump_stack_lvl+0xe2/0x152
> print_address_description.constprop.7+0x21/0x150
> kasan_report_invalid_free+0x6f/0xa0
> __kasan_slab_free+0x125/0x140
> slab_free_freelist_hook+0x10d/0x240
> kfree+0xce/0x390
> iio_device_unregister_sysfs+0x108/0x13b [industrialio]
> iio_dev_release+0x9e/0x10e [industrialio]
> device_release+0xa5/0x240
> kobject_put+0x1e5/0x540
> put_device+0x20/0x30
> devm_iio_device_release+0x21/0x30 [industrialio]
> release_nodes+0xc3/0x3b0
> devres_release_group+0x1da/0x2c0
> i2c_device_probe+0x628/0xbb0
> really_probe+0x285/0xc30

Please, reduce this noise to the ~4-5 important lines only!

--
With Best Regards,
Andy Shevchenko