Re: [PATCH v5] docs: Explain the desired position of function attributes

From: Jonathan Corbet
Date: Tue Oct 12 2021 - 15:35:31 EST


Kees Cook <keescook@xxxxxxxxxxxx> writes:

> While discussing how to format the addition of various function
> attributes, some "unwritten rules" of ordering surfaced[1]. Capture as
> close as possible to Linus's preferences for future reference.
>
> (Though I note the dissent voiced by Joe Perches, Alexey Dobriyan, and
> others that would prefer all attributes live on a separate leading line.)
>
> [1] https://lore.kernel.org/mm-commits/CAHk-=wiOCLRny5aifWNhr621kYrJwhfURsa0vFPeUEm8mF0ufg@xxxxxxxxxxxxxx/
>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> ---
> v5:
> - drop extern (joe)
> - fix __malloc position (miguel)
> v4: https://lore.kernel.org/lkml/20210930235754.2635912-1-keescook@xxxxxxxxxxxx
> ---
> Documentation/process/coding-style.rst | 37 +++++++++++++++++++++++++-
> 1 file changed, 36 insertions(+), 1 deletion(-)

I've applied this, thanks.

jon