Re: [PATCH v3 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe()

[Linus Walleij]

On Fri, Oct 8, 2021 at 11:27 AM Cai Huoqing <caihuoqing@xxxxxxxxx> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
> ---
> v2->v3:
>         *Handle platform_get_irq() that returns -EPROBE_DEFER.
>         *Handle the lack of availability of an IIO channel
>          by converting an -ENODEV to an -EPROBE_DEFER.

This looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij