RE: [PATCH v2 00/23] x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes

[tan.shaopeng@xxxxxxxxxxx]

Hi James,

> Hello!
> 
> Patches 1&2 have been posted independently in case they are wanted as fixes.
> 
> The major change in this version is when the mba_mbps[] array is allocated.
> 
> ---
> The aim of this series is to insert a split between the parts of the monitor code
> that the architecture must implement, and those that are part of the resctrl
> filesystem. The eventual aim is to move all filesystem parts out to live in
> /fs/resctrl, so that resctrl can be wired up for MPAM.
> 
> What's MPAM? See the cover letter of a previous series. [1]
> 
> The series adds domain online/offline callbacks to allow the filesystem to
> manage some of its structures itself, then moves all the 'mba_sc' behaviour to
> be part of the filesystem.
> This means another architecture doesn't need to provide an mbps_val array.
> As its all software, the resctrl filesystem should be able to do this without any
> help from the architecture code.
> 
> Finally __rmid_read() is refactored to be the API call that the architecture
> provides to read a counter value. All the hardware specific overflow detection,
> scaling and value correction should occur behind this helper.
> 
> 
> This series is based on v5.15-rc3, and can be retrieved from:
> git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git
> mpam/resctrl_monitors_in_bytes/v2
> 
> [0] git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git
> mpam/resctrl_merge_cdp/v7 [1]
> https://lore.kernel.org/lkml/20210728170637.25610-1-james.morse@xxxxxxx
> /
> 
> [v1]
> https://lore.kernel.org/lkml/20210729223610.29373-1-james.morse@xxxxxxx
> /

I have tested these patches on Intel(R) Xeon(R) Gold 6254 CPU with resctrl selftest.
It is no problem.

Shaopeng Tan