Re: [PATCH] ARM: dts: am335x: Add rtc node as system-power-controller

From: Johan Hovold
Date: Wed Oct 13 2021 - 03:23:59 EST


On Tue, Oct 12, 2021 at 12:13:12PM -0700, Drew Fustini wrote:
> From: Keerthy <j-keerthy@xxxxxx>
>
> PMIC_PWR_EN pin of RTC on am335x-evm, bone, and boneblack is connected to
> PMIC on board, so flag rtc node as system-power-controller to allow
> software to poweroff boards.

The "system-power-controller" property is already set in
bone-common.dtsi since

2876cc4a773c ("ARM: dts: Move most of am335x-boneblack.dts to am335x-boneblack-common.dtsi")

so this probably only affects am335x-evm and that should be reflected in
the commit message.

Also, should you now remove the property from boneblack-common? Or just
add it to am335x-evm instead?

> Signed-off-by: Dave Gerlach <d-gerlach@xxxxxx>
> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> Signed-off-by: Drew Fustini <dfustini@xxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/am335x-bone-common.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 0ccdc7cd463b..56ae5095a5b8 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -399,6 +399,7 @@ &sham {
> &rtc {
> clocks = <&clk_32768_ck>, <&clk_24mhz_clkctrl AM3_CLK_24MHZ_CLKDIV32K_CLKCTRL 0>;
> clock-names = "ext-clk", "int-clk";
> + system-power-controller;
> };
>
> &pruss_tm {

Johan