Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC

From: Codrin.Ciubotariu
Date: Wed Oct 13 2021 - 04:15:59 EST


On 03.10.2021 06:03, Randy Dunlap wrote:
> Geert pointed out that since sound/soc has the soc_dummy_driver for
> NO_DMA platforms, it is possible (desirable) to have drivers that
> depend on HAS_DMA to alternately depend on COMPILE_TEST.
>
> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
>
> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Cc: alsa-devel@xxxxxxxxxxxxxxxx
> Cc: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>
> ---
> sound/soc/atmel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
> +++ linux-next-20211001/sound/soc/atmel/Kconfig
> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
>
> config SND_ATMEL_SOC_PDC
> bool
> + depends on HAS_DMA || COMPILE_TEST

SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand
the need for this...