RE: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM allocations

[Justin He]

Hi Marc

> -----Original Message-----
> From: Oliver Upton <oupton@xxxxxxxxxx>
> Sent: Monday, September 13, 2021 8:21 PM
> To: Justin He <Justin.He@xxxxxxx>
> Cc: Marc Zyngier <maz@xxxxxxxxxx>; James Morse <James.Morse@xxxxxxx>;
> Alexandru Elisei <Alexandru.Elisei@xxxxxxx>; Suzuki Poulose
> <Suzuki.Poulose@xxxxxxx>; Xiaoming Ni <nixiaoming@xxxxxxxxxx>; Lorenzo
> Pieralisi <Lorenzo.Pieralisi@xxxxxxx>; Kees Cook <keescook@xxxxxxxxxxxx>;
> Catalin Marinas <Catalin.Marinas@xxxxxxx>; Nick Desaulniers
> <ndesaulniers@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Liu Shixin
> <liushixin2@xxxxxxxxxx>; Sami Tolvanen <samitolvanen@xxxxxxxxxx>; Will
> Deacon <will@xxxxxxxxxx>; kvmarm@xxxxxxxxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/2] KVM: arm64: Add memcg accounting to KVM
> allocations
> 
[...]
> > Do you mean kvm_hyp_zalloc_page() here?
> > Seems kvm_hyp_zalloc_page() is in both global and VM scopes.
> 
> Doh! kvm_hyp_zalloc_page() is only for the hyp's page tables, hence I
> believe your patch is correct as it stands. As such:
> 
> Reviewed-by: Oliver Upton <oupton@xxxxxxxxxx>
Kindly ping for the whole series. 😉

--
Cheers,
Justin (Jia He)