Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC

[Codrin.Ciubotariu]

On 13.10.2021 11:40, Geert Uytterhoeven wrote:
> Hi Codrin,
> 
> On Wed, Oct 13, 2021 at 10:15 AM <Codrin.Ciubotariu@xxxxxxxxxxxxx> wrote:
>> On 03.10.2021 06:03, Randy Dunlap wrote:
>>> Geert pointed out that since sound/soc has the soc_dummy_driver for
>>> NO_DMA platforms, it is possible (desirable) to have drivers that
>>> depend on HAS_DMA to alternately depend on COMPILE_TEST.
>>>
>>> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
>>>
>>> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
>>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>> Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>>> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
>>> Cc: Mark Brown <broonie@xxxxxxxxxx>
>>> Cc: alsa-devel@xxxxxxxxxxxxxxxx
>>> Cc: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>
>>> ---
>>>    sound/soc/atmel/Kconfig |    1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
>>> +++ linux-next-20211001/sound/soc/atmel/Kconfig
>>> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
>>>
>>>    config SND_ATMEL_SOC_PDC
>>>           bool
>>> +       depends on HAS_DMA || COMPILE_TEST
>>
>> SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand
>> the need for this...
> 
> Does it work without DMA support?
> If not, it doesn't make much sense to offer this option to the user, unless
> the user is compile-testing.

it is using a Peripheral DMA controller, that is mapped in SSC's address 
space and is not using the DMA engine. I see that HAS_DMA is needed for 
the DMA mapping API, which we use, so I guess we do depend on it. That 
being said:

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@xxxxxxxxxxxxx>

Thanks!