Re: [PATCH v1 06/10] asm-generic: Refactor dereference_[kernel]_function_descriptor()

[Christophe Leroy]

Le 13/10/2021 à 09:02, Kees Cook a écrit :
> On Mon, Oct 11, 2021 at 05:25:33PM +0200, Christophe Leroy wrote:
> > dereference_function_descriptor() and
> > dereference_kernel_function_descriptor() are identical on the
> > three architectures implementing them.
> >
> > Make it common.
> >
> > Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> > ---
> >   arch/ia64/include/asm/sections.h    | 19 -------------------
> >   arch/parisc/include/asm/sections.h  |  9 ---------
> >   arch/parisc/kernel/process.c        | 21 ---------------------
> >   arch/powerpc/include/asm/sections.h | 23 -----------------------
> >   include/asm-generic/sections.h      | 18 ++++++++++++++++++
> >   5 files changed, 18 insertions(+), 72 deletions(-)
>
> A diffstat to love. :)
>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

Unless somebody minds, I will make them out of line as
suggested by Helge in he's comment to patch 4.

Allthough there is no spectacular size reduction, the functions
are not worth being inlined as they are not used in critical pathes.