Re: [PATCH] dma-buf: Update obsoluted comments on dma_buf_vmap/vunmap()

From: Daniel Vetter
Date: Wed Oct 13 2021 - 08:28:20 EST


On Fri, Oct 08, 2021 at 02:09:41PM +0200, Christian König wrote:
> Am 08.10.21 um 13:20 schrieb Shunsuke Mie:
> > A comment for the dma_buf_vmap/vunmap() is not catching up a
> > corresponding implementation.
> >
> > Signed-off-by: Shunsuke Mie <mie@xxxxxxxxxx>
>
> Reviewed-by: Christian König <christian.koenig@xxxxxxx>

You're also pushing?
-Daniel

>
> > ---
> > drivers/dma-buf/dma-buf.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> > index beb504a92d60..7b619998f03a 100644
> > --- a/drivers/dma-buf/dma-buf.c
> > +++ b/drivers/dma-buf/dma-buf.c
> > @@ -1052,8 +1052,8 @@ EXPORT_SYMBOL_GPL(dma_buf_move_notify);
> > *
> > * Interfaces::
> > *
> > - * void \*dma_buf_vmap(struct dma_buf \*dmabuf)
> > - * void dma_buf_vunmap(struct dma_buf \*dmabuf, void \*vaddr)
> > + * void \*dma_buf_vmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
> > + * void dma_buf_vunmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
> > *
> > * The vmap call can fail if there is no vmap support in the exporter, or if
> > * it runs out of vmalloc space. Note that the dma-buf layer keeps a reference
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch