Re: [PATCH] x86: add support DM&P devices

From: Borislav Petkov
Date: Wed Oct 13 2021 - 12:58:11 EST


On Fri, Oct 08, 2021 at 06:22:46PM +0200, Marcos Del Sol Vives wrote:
> +config CPU_SUP_DMP_32
> + default y
> + bool "Support DM&P processors" if PROCESSOR_SELECT
> + depends on !64BIT

You mean

depends on X86_32

?

Wikipedia says those things are 32-bit.

> + help
> + This enables detection, tunings and quirks for DM&P processors
> +
> + You need this enabled if you want your kernel to run on a
> + DM&P CPU. Disabling this option on other types of CPUs

So I'm not sure about the nomenclature: those CPUs are called Vortex86
and DM&P is simply the next owner of the IP:

"Vortex86 previously belonged to SiS, which got the basic design from
Rise Technology.[1] SiS sold it to DM&P Electronics[2] in Taiwan."

So I'm thinking we should call everything Vortex, the file vortex.c, the
vendor define X86_VENDOR_VORTEX and so on.

> + makes the kernel a tiny bit smaller. Disabling it on a DM&P
> + CPU might render the kernel unbootable.

Why unbootable? It looks like those are perfect clones: "No special init
required for DM&P processors." it says in the patch. :)

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette