Re: [PATCH v1 1/1] device property: Add missed header in fwnode.h

From: Saravana Kannan
Date: Wed Oct 13 2021 - 13:21:59 EST


On Wed, Oct 13, 2021 at 7:37 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> When adding some stuff to the header file we must not rely on
> implicit dependencies that are happen by luck or bugs in other
> headers. Hence fwnode.h needs to use bits.h directly.
>
> Fixes: c2c724c868c4 ("driver core: Add fw_devlink_parse_fwtree()")
> Cc: Saravana Kannan <saravanak@xxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Acked-by: Saravana Kannan <saravanak@xxxxxxxxxx>

-Saravana

> ---
> include/linux/fwnode.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 9f4ad719bfe3..3a532ba66f6c 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -11,6 +11,7 @@
>
> #include <linux/types.h>
> #include <linux/list.h>
> +#include <linux/bits.h>
> #include <linux/err.h>
>
> struct fwnode_operations;
> --
> 2.33.0
>